Potential performance issue in SimpleQueuedHandler and consultancy

EventStoreDB
#1

Hi,

I’m just looking at the SimpleQueuedHandler class whilst trying to implement a feature. I’m interested to know why linq is not being used when checking the queue length, instead of count !=0? Would this impact performance?

Also, How do I go about getting some commercial consultancy?

Help appreciated as always.

Kind regards

Sean.

#2

Contact support @ geteventstore.com cc greg@

For simplequeuedhandler where are you referring to?
https://github.com/EventStore/EventStore/blob/release-v4.0.0/src/EventStore.ClientAPI/Internal/SimpleQueuedHandler.cs

#3

Hi Greg,
I'm referring to line 45.
Cheers
Sean.

#4

its not using linq?
https://msdn.microsoft.com/en-us/library/dd267339(v=vs.110).aspx

Cheers,

Greg

#5

No, Count will still iterate through every element, the Linq namespace is not referenced at all in that file.

#6

There is a difference between Count() the method on IEnumerable
https://msdn.microsoft.com/en-us/library/bb338038(v=vs.100).aspx and
Count the property on ConcurrentQueue
https://msdn.microsoft.com/en-us/library/dd267339(v=vs.110).aspx.

Note its using .Count not .Count()

#7

True, even so, shouldn't it then be using IsEmpty? .Count seems overkill?

#8

Feel free to measure, If this is a bottleneck on an IO bound operation
I would be amazed.