EventStore.ClientAPI.SubscribeToAllFrom subscriptionDropped callback action not called when unhandlable "Drop reason not specified." Exception raised

version: EventStore nuget package 3.2.1

symptom (with Windows Forms test application):
using EventStore.ClientAPI.SubscribeToAllFrom method when “Drop reason not specified” exception is raised internally subscriptionDropped callback action is not called shutting down client application.

I’ve personally fixed this in EventStoreCatchUpSubscription.cs method EventStore.ClientApi.ProcessLiveQueue at line 281 changing:

if (_dropData ==) throw new Exception(“Drop reason not specified.”);

else

DropSubscription(_dropData.Reason, _dropData.Error);

in:

if (_dropData == null)

DropSubscription(SubscriptionDropReason.Unknown, new Exception(“Drop reason not specified.”));

else

DropSubscription(_dropData.Reason, _dropData.Error);

Giuseppe

Giuseppe

WindowsFormsApplication1.7z (578 KB)

I'm not sure I understand your change as :

   if (_dropData ==) throw new Exception("Drop reason not specified.");
            else
              DropSubscription(_dropData.Reason, _dropData.Error);

isn't compilable code.

sorry …

if (_dropData == null) throw new Exception(“Drop reason not specified.”);

G.